Why my Delete Cascade policy is not working Properly

ghz 8months ago ⋅ 62 views

I have 2 tables called Domain and Domain Theme. it has one to one relationship. Here the 2 model classes.

public class Domain
    {
        
        public int OrganizationDomainId { get; set; }
        [MaxLength(200), Required]
        public string Domain { get; set; }
        public bool Active { get; set; }
        public int? ThemeId { get; set; }
        [ForeignKey("ThemeId")]
        public virtual OrganizationDomainTheme OrganizationDomainTheme {get;set;}

    }
public class OrganizationDomainTheme
    {
        public int OrganizationDomainThemeId { get; set; }
        public string PrimaryColor{get;set;}
        public virtual OrganizationDomain OrganizationDomain { get; set; }
        
    }

I have implemented a delete behavior by using model builder for my 2 tables.

  1. Set Domain Null when i delete a Theme. (this is working fine)
modelBuilder.Entity<OrganizationDomainTheme>()
                .HasOne(odt => odt.OrganizationDomain)
                .WithOne(od => od.OrganizationDomainTheme)
                .OnDelete(DeleteBehavior.SetNull);
  1. Delete Domain Should delete the Theme.(This is not working as expected)
modelBuilder.Entity<OrganizationDomain>()
                .HasOne(od => od.OrganizationDomainTheme)
                .WithOne(odt=>odt.OrganizationDomain)
                .OnDelete(DeleteBehavior.Cascade);

Senario.

When i delete a Theme it sets the Domain Null as i expected from number 1.

But When i delete a Domain it will not delete the Theme. Theme is still on the table.

Am i configure it wrong ? Please Help.

I want to delete the theme that belong to the domain when i delete a domain.

Answers

It seems like you want to establish a one-to-one relationship between the Domain and DomainTheme tables, where deleting a Domain should also delete the associated DomainTheme. However, your current configuration is not achieving this behavior.

To accomplish your requirement, you need to configure the relationship between Domain and DomainTheme correctly using fluent API in Entity Framework Core. Here's how you can do it:

modelBuilder.Entity<Domain>()
    .HasOne(d => d.OrganizationDomainTheme)
    .WithOne(dt => dt.OrganizationDomain)
    .HasForeignKey<OrganizationDomainTheme>(dt => dt.OrganizationDomainId)
    .OnDelete(DeleteBehavior.Cascade);

With this configuration, deleting a Domain will also delete the associated DomainTheme. Make sure you define the foreign key relationship explicitly in the OrganizationDomainTheme entity.

Additionally, you need to ensure that cascading delete is enabled in your database schema for this behavior to take effect. Otherwise, you may encounter referential integrity errors when trying to delete a Domain that has an associated DomainTheme.

Here's how your updated model classes and fluent API configuration should look like:

public class Domain
{
    public int OrganizationDomainId { get; set; }
    [MaxLength(200), Required]
    public string Domain { get; set; }
    public bool Active { get; set; }
    public int? ThemeId { get; set; }
    [ForeignKey("ThemeId")]
    public virtual OrganizationDomainTheme OrganizationDomainTheme { get; set; }
}

public class OrganizationDomainTheme
{
    public int OrganizationDomainThemeId { get; set; }
    public string PrimaryColor { get; set; }
    public int OrganizationDomainId { get; set; } // Foreign key
    public virtual Domain OrganizationDomain { get; set; }
}

// Configuration in your DbContext's OnModelCreating method
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
    base.OnModelCreating(modelBuilder);

    modelBuilder.Entity<Domain>()
        .HasOne(d => d.OrganizationDomainTheme)
        .WithOne(dt => dt.OrganizationDomain)
        .HasForeignKey<OrganizationDomainTheme>(dt => dt.OrganizationDomainId)
        .OnDelete(DeleteBehavior.Cascade);
}

With this configuration, deleting a Domain will cascade delete its associated OrganizationDomainTheme.

#.net